Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: disable "Open report" button when UI is displayed from the controller #721

Closed
andre8244 opened this issue Aug 27, 2024 · 10 comments
Closed
Assignees
Labels
controller The issue is related to the controller verified All test cases were verified successfully

Comments

@andre8244
Copy link
Collaborator

andre8244 commented Aug 27, 2024

"Open report" button in "Report" page is not working when unit UI is accessed from the controller, so the button has to be disabled and show an explanatory tooltip.

@andre8244 andre8244 converted this from a draft issue Aug 27, 2024
@andre8244 andre8244 self-assigned this Aug 27, 2024
@gsanchietti gsanchietti added this to the NethSecurity 8.3 milestone Sep 2, 2024
@gsanchietti gsanchietti added the controller The issue is related to the controller label Sep 2, 2024
@andre8244 andre8244 added the testing Packages are available from testing repositories label Sep 4, 2024
@andre8244
Copy link
Collaborator Author

andre8244 commented Sep 4, 2024

Testing controller version: ghcr.io/nethserver/nethsecurity-controller:0.0.25

@andre8244
Copy link
Collaborator Author

Test case

  • Connect the unit to a controller
  • Open unit UI from the controller
  • Go to Report page
  • Verify the Open report button is disabled and shows an explanatory tooltip on hover

@andre8244 andre8244 assigned Tbaile and unassigned andre8244 Sep 4, 2024
@Tbaile
Copy link
Contributor

Tbaile commented Sep 4, 2024

Verified using controller version 0.0.25

@Tbaile Tbaile added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Sep 4, 2024
@gsanchietti
Copy link
Member

The release of the "ns8-nethsecurity-controller" update has been suspended due to a compatibility issue identified between the new UI version 1.2.0 and the older version 1.1.0 still in use on many machines.

The update would introduce the 1.2.0 version of the Nethsecurity UI. However, since a significant number of machines are still running version 1.1.0, there is a risk that users accessing these machines via an updated controller might encounter compatibility issues. Specifically, the frontend from version 1.2.0 might attempt to interact with APIs that do not exist in the 1.1.0 backend, potentially leading to errors or malfunctions.

To prevent these issues, the release has been paused until a solution is found to ensure compatibility across the different versions in use.

@Tbaile
Copy link
Contributor

Tbaile commented Sep 5, 2024

Here's the list of what to do to implement Version Awarness for the Controller:

@Tbaile
Copy link
Contributor

Tbaile commented Sep 9, 2024

QA (to be edited when PRs close):

  1. Outdated firewall
  • Install the controller using branch version: add-module ghcr.io/nethserver/nethsecurity-controller:version-bump
  • Connect a stable firewall, ensure that's not possible to connect to it, a popup should appear prohibiting to do so
  1. Up to date firewall
  • Install the controller using branch version: add-module ghcr.io/nethserver/nethsecurity-controller:version-bump
  • Update a stable firewall using this version: link
  • When connecting to the unit through the controller, ensure no popup is visible and the firewall opens correctly
  1. Outdated controller
  • Install the controller using branch version: add-module ghcr.io/nethserver/nethsecurity-controller:version-bump
  • Update a stable firewall using this version: link
  • MANUAL EDIT: edit the file /usr/libexec/rpcd/ns.controller in the unit, at row 67, replace it's content with the following:
    ret["api_version"] = "1.1.0"
  • Connect the controller and the unit, ensure that a warning providing info regards of mismatched version appears, HOWEVER it's still possible to connect to the unit through the modal.

@Tbaile Tbaile added bug testing Packages are available from testing repositories and removed verified All test cases were verified successfully labels Sep 9, 2024
@gsanchietti gsanchietti assigned gsanchietti and unassigned Tbaile Sep 10, 2024
@gsanchietti
Copy link
Member

Test case 1 on report button is verified.

@gsanchietti
Copy link
Member

Test case failed.

This is the error reported by controller when trying to connect to and old firewall:
Screenshot from 2024-09-10 14-57-36

API command line execution:

curl -X GET 'https://console.gs.nethserver.net/api/units/undefined/info' --insecure -H 'Content-Type: application/json' -H 'Authorization: Bearer xxx' 
{"code":400,"data":"error getting token","message":"can't get unit info for: undefined"}

@gsanchietti
Copy link
Member

Tested with latest image: the error was present only if the "don't show again" option was never clicked.
This case is now handled correctly.

Verified

@gsanchietti gsanchietti added the verified All test cases were verified successfully label Sep 10, 2024
@gsanchietti
Copy link
Member

Released version 1.0.0.

@github-project-automation github-project-automation bot moved this from In progress 🛠 to Done ✅ in NethSecurity Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller The issue is related to the controller verified All test cases were verified successfully
Projects
Archived in project
Development

No branches or pull requests

3 participants