Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend items order when using diff_waveform in plot_conditions #226

Open
sotofernando opened this issue Mar 17, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working EEG-ExPy

Comments

@sotofernando
Copy link

ℹ Computer information

  • Platform OS: Mac
  • Python Version: 3.7
  • Brain Interface Used: Muse

📝 Provide detailed reproduction steps (if any)

  1. Run examples/visual_p300/01r__p300_viz.py

✔️ Expected result

image

I think is just changing order when concatenating lists in https://github.com/NeuroTechX/eeg-notebooks/blob/master/eegnb/analysis/utils.py#L307

Instead of:

        legend = ["{} - {}".format(diff_waveform[1], diff_waveform[0])] + list(
            conditions.keys()
        )

could be something like:
legend = list(conditions.keys()) + ["{} - {}".format(diff_waveform[1], diff_waveform[0])]

❌ Actual result

image

📷 Screenshots

To check and identify wave forms and legend items, I compared with Alexandre's article in: http://alexandre.barachant.org/blog/2017/02/05/P300-with-muse.html

image

@sotofernando sotofernando added the bug Something isn't working label Mar 17, 2023
@tmorshed tmorshed self-assigned this Apr 6, 2023
@pellet
Copy link
Contributor

pellet commented Apr 9, 2023

I've had a similar issue with visualizing the N170 example data data:
image (2)

The issue is not occurring when reverting eeg-notebooks back to the revision which is using seaborn v0.9.0 for line plotting - before develop was merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EEG-ExPy
Projects
None yet
Development

No branches or pull requests

4 participants