From 4b6509113622f9ed39c61a1c478a44b2c6e3aabb Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 3 Oct 2024 09:58:34 -0700 Subject: [PATCH 1/4] Add workflows to test without dandi reqs --- .github/workflows/streaming-tests.yml | 26 ++++++++++++++++++++++++++ .github/workflows/testing.yml | 26 ++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) diff --git a/.github/workflows/streaming-tests.yml b/.github/workflows/streaming-tests.yml index 5871fa31..79688eb6 100644 --- a/.github/workflows/streaming-tests.yml +++ b/.github/workflows/streaming-tests.yml @@ -51,3 +51,29 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true file: ./cli_coverage.xml + + build-and-test-no-dandi: + name: Testing using ${{ matrix.os }} with ${{ matrix.python-version }} without dandi dependencies + runs-on: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + os: ["ubuntu-latest"] + python-version: ["3.12"] + steps: + - uses: actions/checkout@v4 + - run: git fetch --prune --unshallow --tags + + - name: Setup Python + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + + - name: Install pytest + run: pip install pytest + + - name: Install package + run: pip install . + + - name: Run pytest with coverage + run: pytest -rsx diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index c818d7e6..61cf7137 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -46,3 +46,29 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true file: ./coverage.xml + + build-and-test-no-dandi: + name: Testing using ${{ matrix.os }} with ${{ matrix.python-version }} without dandi dependencies + runs-on: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + os: ["ubuntu-latest"] + python-version: ["3.12"] + steps: + - uses: actions/checkout@v4 + - run: git fetch --prune --unshallow --tags + + - name: Setup Python + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + + - name: Install pytest + run: pip install pytest + + - name: Install package + run: pip install . + + - name: Run pytest with coverage + run: pytest -rsx From a04e98ee128cfb0a8339278ba4a3e5c4a9d42590 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 3 Oct 2024 16:59:17 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .github/workflows/streaming-tests.yml | 2 +- .github/workflows/testing.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/streaming-tests.yml b/.github/workflows/streaming-tests.yml index 79688eb6..a9d1b2bd 100644 --- a/.github/workflows/streaming-tests.yml +++ b/.github/workflows/streaming-tests.yml @@ -76,4 +76,4 @@ jobs: run: pip install . - name: Run pytest with coverage - run: pytest -rsx + run: pytest -rsx diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 61cf7137..41eab2a9 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -71,4 +71,4 @@ jobs: run: pip install . - name: Run pytest with coverage - run: pytest -rsx + run: pytest -rsx From 6da92e83affe561e420ab702342455722ff2b6dc Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 3 Oct 2024 11:02:47 -0700 Subject: [PATCH 3/4] Re-add download of testing data --- .github/workflows/testing.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 41eab2a9..2b036300 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -70,5 +70,8 @@ jobs: - name: Install package run: pip install . + - name: Download testing data and set config path + run: dandi download "https://gui-staging.dandiarchive.org/#/dandiset/204919" + - name: Run pytest with coverage run: pytest -rsx From a8c68b166639fa3aa8e1de0fbe5f31df0b17ab53 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 3 Oct 2024 11:05:17 -0700 Subject: [PATCH 4/4] Undo last change, limit test data testing --- .github/workflows/testing.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 2b036300..9eda2f42 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -5,9 +5,6 @@ on: CODECOV_TOKEN: required: true -env: - TESTING_FILES_FOLDER_PATH: ./204919/testing_files/ - jobs: build-and-test: name: Testing using ${{ matrix.os }} with ${{ matrix.python-version }} @@ -17,6 +14,8 @@ jobs: matrix: os: ["ubuntu-latest", "macos-13", "windows-latest"] python-version: ["3.9", "3.10", "3.11", "3.12"] + env: + TESTING_FILES_FOLDER_PATH: ./204919/testing_files/ steps: - uses: actions/checkout@v4 - run: git fetch --prune --unshallow --tags @@ -70,8 +69,5 @@ jobs: - name: Install package run: pip install . - - name: Download testing data and set config path - run: dandi download "https://gui-staging.dandiarchive.org/#/dandiset/204919" - - name: Run pytest with coverage run: pytest -rsx