You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
H5DataIO[slice] currently throws an error. I would like it instead to call H5DataIO.data[slice].
Motivations
This is clearly the intention.
It will help with tests. I am running into an issue with the unit tests when trying to implement Make all DynamicTables chunked and resizable by default #1067 the unit tests break because several of them try to index data without checking if it's an H5DataIO object. With the proposed change, we can simply say something like assert data_out[:] == data_in and this will work whether data_out is a list, h5py.Dataset, np.array, or H5DataIO object.
The text was updated successfully, but these errors were encountered:
H5DataIO[slice]
currently throws an error. I would like it instead to callH5DataIO.data[slice]
.Motivations
data
without checking if it's anH5DataIO
object. With the proposed change, we can simply say something likeassert data_out[:] == data_in
and this will work whetherdata_out
is alist
,h5py.Dataset
,np.array
, orH5DataIO
object.The text was updated successfully, but these errors were encountered: