Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Append a dataset of references #1951

Open
3 tasks done
mavaylon1 opened this issue Aug 21, 2024 · 2 comments
Open
3 tasks done

[Documentation]: Append a dataset of references #1951

mavaylon1 opened this issue Aug 21, 2024 · 2 comments
Assignees
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation

Comments

@mavaylon1
Copy link
Collaborator

What would you like changed or added to the documentation and why?

Update or create documentation for appending a dataset of references. I am thinking ecephys.

Do you have any interest in helping write or edit the documentation?

Yes.

Code of Conduct

@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior topic: docs issues related to documentation priority: low alternative solution already working and/or relevant to only specific user(s) labels Aug 21, 2024
@mavaylon1 mavaylon1 self-assigned this Aug 21, 2024
@cboulay
Copy link

cboulay commented Aug 28, 2024

I'm wondering if my issue is the covered by this or the linked PR in hdmf. Please advise.

I am iteratively writing to multiple containers (acquisitions and epochs table) in a single NWB file. I would like more than one of the acquisitions to be an ElectricalSeries, however I cannot append to the electrodes table after I've done an io.write(nwbfile) and io = pynwb.NWBHDF5IO(..., mode="a") because the datasets are now h5py.Dataset which cannot (by default) be reshaped.

I tried to get past this by doing nwbfile.electrodes.id.set_data_io(H5DataIO, {"maxshape": (None,)}) for id and all the other fields in the electrodes table before the first write and re-open. However, this has little effect for the group field because after re-opening this field is a dataset of references that cannot be reshaped.

Is this issue addressed by the above changes to hdmf?

@stephprince
Copy link
Contributor

stephprince commented Aug 29, 2024

@cboulay I was testing out the linked PR in hdmf for your electrodes table use case, and there is one remaining bug in hdmf that needs to be resolved before appending to the electrodes table will work.

Linking the related issue here, I think we have a working solution and just need to add some further tests before it will be incorporated into hdmf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Development

No branches or pull requests

3 participants