Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpr_sp_watershed - add param col_id #66

Open
NewGraphEnvironment opened this issue Apr 4, 2024 · 0 comments
Open

fpr_sp_watershed - add param col_id #66

NewGraphEnvironment opened this issue Apr 4, 2024 · 0 comments

Comments

@NewGraphEnvironment
Copy link
Owner

Add param col_id with default stream_crossing_id to allow backwards compatibility and future flexibility for content of dataframe provided. Should work to address watershed area generation for NewGraphEnvironment/fish_passage_fraser_2023_reporting#59

#' Retrieve watershed geometry using fwapg

May as well put as stand alone script to avoid shopping around in spatial.R at the same time

Can be tested for backwards compatibility using past fp repo scripts in scripts/02_reporting/0170-load_wshd_stats.R

no action required now but:
Considering eventually moving fpr_sp functions that are not really "fish passage reporting spatial" specific (especially when stream_crossing_id is parameterized) to separate package

This function has always been called as part of report setup (vs build) so deprecating completely after move will not break any past reports but perhaps just a note to user (and badge) in the help that there is a new function somewhere (superseded) would work fine and allow updates to watershed areas using unaltered historic repo scripts if required...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant