You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add param col_id with default stream_crossing_id to allow backwards compatibility and future flexibility for content of dataframe provided. Should work to address watershed area generation for NewGraphEnvironment/fish_passage_fraser_2023_reporting#59
May as well put as stand alone script to avoid shopping around in spatial.R at the same time
Can be tested for backwards compatibility using past fp repo scripts in scripts/02_reporting/0170-load_wshd_stats.R
no action required now but:
Considering eventually moving fpr_sp functions that are not really "fish passage reporting spatial" specific (especially when stream_crossing_id is parameterized) to separate package
This function has always been called as part of report setup (vs build) so deprecating completely after move will not break any past reports but perhaps just a note to user (and badge) in the help that there is a new function somewhere (superseded) would work fine and allow updates to watershed areas using unaltered historic repo scripts if required...
The text was updated successfully, but these errors were encountered:
Add param
col_id
with defaultstream_crossing_id
to allow backwards compatibility and future flexibility for content of dataframe provided. Should work to address watershed area generation for NewGraphEnvironment/fish_passage_fraser_2023_reporting#59fpr/R/spatial.R
Line 30 in b9eb9d3
May as well put as stand alone script to avoid shopping around in
spatial.R
at the same timeCan be tested for backwards compatibility using past fp repo scripts in
scripts/02_reporting/0170-load_wshd_stats.R
no action required now but:
Considering eventually moving
fpr_sp
functions that are not really "fish passage reporting spatial" specific (especially whenstream_crossing_id
is parameterized) to separate packageThis function has always been called as part of report setup (vs build) so deprecating completely after move will not break any past reports but perhaps just a note to user (and badge) in the help that there is a new function somewhere (superseded) would work fine and allow updates to watershed areas using unaltered historic repo scripts if required...
The text was updated successfully, but these errors were encountered: