Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images sent from Nheko do not show up in Mirage #549

Closed
MRAAGH opened this issue Apr 13, 2021 · 5 comments
Closed

Images sent from Nheko do not show up in Mirage #549

MRAAGH opened this issue Apr 13, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@MRAAGH
Copy link

MRAAGH commented Apr 13, 2021

Describe the bug

Mirage client does not show images sent using Nheko (mirukana/mirage#197)

To reproduce

  1. Send any image in an encrypted room using the Nheko client
  2. Look at the same room in the Mirage client
  3. Notice that the image does not display
  4. Look at the downloaded file and notice it is not a valid image file

Screenshots

Image being sent in Nheko:

Image fails to display in Mirage:

System:

  • Nheko version: 0.8.1-18e96d5c | Linux
  • Profile used: default
  • Installation method: AUR package nheko-git
  • Operating System: Arch Linux 64-bit
  • Qt version: 5.15.2
  • C++ compiler: g++ 10.2.0
  • Desktop Environment: Awesome wm v4.3
@MRAAGH MRAAGH added the bug Something isn't working label Apr 13, 2021
@deepbluev7
Copy link
Member

If I send the file and download it again in any client I have (which is not mirage), the checksums are exactly the same. Are you sure this is not just a mirage bug? Does this only happen in specific types of rooms, like encrypted rooms?

@deepbluev7
Copy link
Member

One thing I can imagine, is that in encrypted rooms Nheko only sends the mimetype in the info object, not in the file object. See matrix-org/matrix-spec-proposals#2582

@MRAAGH
Copy link
Author

MRAAGH commented Apr 13, 2021

Turns out images display fine in unencrypted rooms. This only happens in encrypted rooms.
That about the mimetypes is a possible cause @mirukana

@deepbluev7
Copy link
Member

Yeah, Nheko does not send the mimetype, because the spec only has that in the example and not in the actual event spec. And we want it to be removed instead, because it is redundant.

@deepbluev7
Copy link
Member

Closing, as imo Nheko is spec compliant enough here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants