Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix build --keep-going doesn't report what failed #11347

Open
viperML opened this issue Aug 21, 2024 · 3 comments
Open

nix build --keep-going doesn't report what failed #11347

viperML opened this issue Aug 21, 2024 · 3 comments
Labels

Comments

@viperML
Copy link

viperML commented Aug 21, 2024

Describe the bug

When using --keep-going, nix reports build failures as they come. At the end, it only reports the number of packages that failed, but not their names. The names will be hidden in log history.

Steps To Reproduce

with import <nixpkgs> {}; let
  mkFailing = name:
    pkgs.runCommandLocal name {} ''
      exit 1
    '';
in
  linkFarmFromDrvs "farm" [
    (mkFailing "drv-a")
    (mkFailing "drv-b")
    (mkFailing "drv-c")
    (runCommandLocal "many-logs" {} ''
      for i in $(seq 1 10); do
        echo ":: doing stuff"
      done
      touch $out
    '')
  ]
$ nix build -f ./test.nix --keep-going -L
error: builder for '/nix/store/pyh081a8vvhcar6m2qip5q3i8gzqinm6-drv-a.drv' failed with exit code 1
error: builder for '/nix/store/6mbsj7b18ww8mr21ac8k5jnhd65lravh-drv-b.drv' failed with exit code 1
error: builder for '/nix/store/jyz83cbvqni6ck8j06rpd9zg1j0hfnb0-drv-c.drv' failed with exit code 1
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
many-logs> :: doing stuff
error: 3 dependencies of derivation '/nix/store/jx7wa9qv6dkqb1kjwvmhwqpn4syd9q3j-farm.drv' failed to build

Expected behavior

This report is generated by nix-output-monitor, so I would expect something similar:

┃ ├─ ⚠ drv-a failed with exit code 1 after ⏱ 0s
┃ ├─ ⚠ drv-c failed with exit code 1 after ⏱ 0s
┃ ├─ ⚠ drv-b failed with exit code 1 after ⏱ 0s

Additional context

Priorities

Add 👍 to issues you find important.

@viperML viperML added the bug label Aug 21, 2024
@Kranzes
Copy link
Member

Kranzes commented Aug 25, 2024

Shouldn't this do the job? #10734 (it's in 2.24)

@viperML
Copy link
Author

viperML commented Aug 25, 2024

Could you try if that's the case?

@Kranzes
Copy link
Member

Kranzes commented Aug 25, 2024

hmm, output looks the same, sorry maybe that's just for FODs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants