Update toml11

[p01arst0rm]

Motivation

Changes to the source structure are required in preparation for accepting the meson buildsystem. including thirdparty files inside the nix source is not recommended, as it impacts portability and complicates building, and introduces unknown/undeclared dependencies which may cause conflicts on user's systems. these issues are fixed by separating out thirdparty code and properly declaring it, as in #3160.

Context

• The Toml11 source has been moved to /subprojects/toml11
• The Toml11 source has been updated to offficial version 3.8.1
• The Toml11 source has been patched to fix building.

[p01arst0rm]

related:

#3160
NixOS/rfcs#132

[edolstra]

Can't we just remove the vendored toml11 and pull it in as an external dependency?

[p01arst0rm]

Can't we just remove the vendored toml11 and pull it in as an external dependency?

yes, this is fixed in the meson build. for now, the files only have to be moved. assuming that the meson build is committed, there is no need to fix this issue twice in the old and new buildsystem.

[Ericson2314]

Yeah @p01arst0rm we really don't want to vendor large libraries like this. Developers can manually unpack them as a sub-project if they like, but they should not be committed in place.

[p01arst0rm]

while i agree moving away from vendoring the files is ideal, and is exactly what the goal is, there are a lot of other annoying issues with allowing either nix or meson to provide toml11. toml11 is already currently vendored, so this PR changes nothing other than the file locations and versions to allow the meson build to use them.

If youre absolutely sure that these files are not movable and should be deleted, an issue should be opened and the nix flake updated.

[p01arst0rm]

any update on merging?

[Ericson2314]

Closing in favor of #10972: un-vendoring is better than updating a vendor. :)