-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttrCursor: Remove forceErrors #10564
Conversation
Actually I am not longer able to reproduce the eval error with nix 2.22.0, also it happens for nix 2.18. Also the test you wrote works even if the fix is not applied. |
@Mic92 I can't reproduce that. The test does fail for me without the fix:
|
Instead, force evaluation of the original value only if we need to show the exception to the user.
d811a40
to
eeb4c40
Compare
Ok. I was able to reproduce this now as well: #10813 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-06-03-nix-team-meeting-minutes-149/46582/1 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.22-maintenance
git worktree add -d .worktree/backport-10564-to-2.22-maintenance origin/2.22-maintenance
cd .worktree/backport-10564-to-2.22-maintenance
git switch --create backport-10564-to-2.22-maintenance
git cherry-pick -x 8b86f415c1a8565085e70475933e459a29d67283 2c88930ef298f6804eb9c064ca918aef01fcd2e3 eeb4c408670a6037bd4085fde654bf4a5945c4c7 |
1 similar comment
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.22-maintenance
git worktree add -d .worktree/backport-10564-to-2.22-maintenance origin/2.22-maintenance
cd .worktree/backport-10564-to-2.22-maintenance
git switch --create backport-10564-to-2.22-maintenance
git cherry-pick -x 8b86f415c1a8565085e70475933e459a29d67283 2c88930ef298f6804eb9c064ca918aef01fcd2e3 eeb4c408670a6037bd4085fde654bf4a5945c4c7 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.23-maintenance
git worktree add -d .worktree/backport-10564-to-2.23-maintenance origin/2.23-maintenance
cd .worktree/backport-10564-to-2.23-maintenance
git switch --create backport-10564-to-2.23-maintenance
git cherry-pick -x 8b86f415c1a8565085e70475933e459a29d67283 2c88930ef298f6804eb9c064ca918aef01fcd2e3 eeb4c408670a6037bd4085fde654bf4a5945c4c7 |
1 similar comment
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.23-maintenance
git worktree add -d .worktree/backport-10564-to-2.23-maintenance origin/2.23-maintenance
cd .worktree/backport-10564-to-2.23-maintenance
git switch --create backport-10564-to-2.23-maintenance
git cherry-pick -x 8b86f415c1a8565085e70475933e459a29d67283 2c88930ef298f6804eb9c064ca918aef01fcd2e3 eeb4c408670a6037bd4085fde654bf4a5945c4c7 |
Motivation
This should remove all "cached failure of attribute X" messages by forcing evaluation of the original value when it's needed to show the exception to the user.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.