Stop vendoring toml11 #10972
Merged
Stop vendoring toml11 #10972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somewhat related to #10330, I guess |
Closed
Ericson2314
force-pushed
the
no-vendor-toml11
branch
2 times, most recently
from
a7c8384
to
48d6328
Compare
We just don't need it!
We don't apply any patches to it, and vendoring it locks users into bugs (it hasn't been updated since its introduction in late 2021). Closes https://git.lix.systems/lix-project/lix/issues/164 Change-Id: Ied071c841fc30b0dfb575151afd1e7f66970fdb9 (cherry picked from commit 80405d0)
Ericson2314
force-pushed
the
no-vendor-toml11
branch
from
48d6328
to
149d8eb
Compare
Artturin
reviewed
Jun 27, 2024
| @@ -225,6 +226,10 @@ in { | |||
| libsodium | |||
| openssl | |||
| sqlite | |||
| (toml11.overrideAttrs (old: { | |||
| # TODO change in Nixpkgs, Windows works fine. | |||
| meta.platforms = lib.platforms.all; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't apply any patches to it, and vendoring it locks users into bugs (it hasn't been updated since its introduction in late 2021).
Closes https://git.lix.systems/lix-project/lix/issues/164
Change-Id: Ied071c841fc30b0dfb575151afd1e7f66970fdb9 (cherry picked from commit 80405d0)
Context
Taken from Lix, thanks @winterqt!
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.