No make unittests #11301
Merged
No make unittests #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Merged
Now that we can run all tests with Meson, we want developers making code changes to use it. (Only the manual needs to be built with the build system, and that will change shortly.) This reverts commit b0bc2a9.
Ericson2314
force-pushed
the
no-make-unittests
branch
7 times, most recently
from
d52ccf6
to
b8b679c
Compare
roberth
reviewed
Aug 14, 2024
| @@ -222,7 +222,7 @@ | |||
| # for which we don't apply the full build matrix such as cross or static. | |||
| inherit (nixpkgsFor.${system}.native) | |||
| changelog-d; | |||
| default = self.packages.${system}.nix; | |||
| default = self.packages.${system}.nix-ng; | |||
There was a problem hiding this comment.
This is good because it preserves the property that nix build . only works if the tests pass.
Ericson2314
force-pushed
the
no-make-unittests
branch
2 times, most recently
from
14d0ae1
to
ec4d347
Compare
This ensures just `nix build`-ing the flake doesn't forget to run all tests. One can still specifiy specific attributes to just build one thing. Co-authored-by: Robert Hensing <[email protected]>
Ericson2314
force-pushed
the
no-make-unittests
branch
from
7964c83
to
b41cc1a
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-08-14-nix-team-meeting-minutes-169/50633/1 |
|
Ehm, how am I supposed to run unit tests now? Please revert, removing make functionality seems premature. |
Merged
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-08-19-nix-team-meeting-minutes-170/50942/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we can run all tests with Meson, we want developers making code changes to use it.
(Only the manual needs to be built with the build system, and that will change shortly.)
This reverts commit b0bc2a9.
Context
#2503
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.