doc/manual/local.mk: use local src/nix/nix instead of /usr/bin/nix #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build failure happens when one tries to build `nix` on a linux system as user with later plan to install as root (typical package building separation): ``` $ cd /tmp $ git clone https://github.com/NixOS/nix.git $ cd nix $ ./bootstrap.sh $ ./configure --prefix=/usr ac_cv_header_aws_s3_S3Client_h=no $ make ... $ LANG=C make LD /usr/lib/libnixutil.so /usr/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot open output file /usr/lib/libnixutil.so: Permission denied collect2: error: ld returned 1 exit status make: *** [mk/lib.mk:117: /usr/lib/libnixutil.so] Error 1 ``` Build failure happens because `doc/manual/nix.json` depends on installed `$(bindir)` path instead of local inplace path: ``` $ make -r -d doc/manual/nix.json ... Considering target file 'doc/manual/nix.json'. File 'doc/manual/nix.json' does not exist. Considering target file '/usr/bin/nix'. Considering target file 'src/build-remote/build-remote.o'. Looking for an implicit rule for 'src/build-remote/build-remote.o'. ... doc/manual/local.mk:$(d)/nix.json: $(bindir)/nix ``` The fix is to always use inplace built `src/nix/nix` binary. Closes: #5184
|
Maybe we should get rid of the default make target, since |
|
Closing this one in favor of #5145. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build failure happens when one tries to build
nixon a linuxsystem as user with later plan to install as root (typical package
building separation):
Build failure happens because
doc/manual/nix.jsondependson installed
$(bindir)path instead of local inplace path:The fix is to always use inplace built
src/nix/nixbinary.Closes: #5184