Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to Uninstall instructions about macOS behavior #639

Open
lilyball opened this issue Nov 5, 2020 · 2 comments
Open

Add warning to Uninstall instructions about macOS behavior #639

lilyball opened this issue Nov 5, 2020 · 2 comments
Assignees
Labels
bug Something isn't working content

Comments

@lilyball
Copy link
Member

lilyball commented Nov 5, 2020

The install instructions today simply say to rm -rf /nix.

<article id="nix-uninstall">
<h2>Uninstall</h2>
<p>
You can uninstall Nix simply by running <code>rm -rf /nix</code>.
</p>
<!-- TODO: expand this https://github.com/NixOS/nix/issues/1402 -->
</article>

This does not work on macOS, where /nix is a mounted volume. The issue referenced in the HTML comment (NixOS/nix#1402) has some macOS-specific information, though really the canonical uninstall instructions come from the create-darwin-volume.sh script used during install:

        echo "  1. Remove the entry from fstab using 'sudo vifs'"
        echo "  2. Destroy the data volume using 'diskutil apfs deleteVolume'"
        echo "  3. Remove the 'nix' line from /etc/synthetic.conf or the file"

(note that these steps will change with NixOS/nix#4181).

Ideally we'd keep the website updated with the full set of steps, but in the meantime, we should at least add a caveat here saying that these instructions aren't sufficient on macOS and point the user toward somewhere else (such as NixOS/nix#1402). Once NixOS/nix#4181 is merged our installer approach for macOS should be stabilized and we can then update the website with more explicit instructions.

@garbas
Copy link
Member

garbas commented Nov 9, 2020

@lilyball 👍 Would you be so kind and try to provide a PR? I'm currently a bit overwhelmed with the work and any help is much appreciated.

@garbas garbas added bug Something isn't working content labels Nov 9, 2020
@edolstra
Copy link
Member

edolstra commented Nov 9, 2020

If we need extensive uninstall instructions, it's probably better to add them to the Nix manual (and link to them from here), to avoid ending up with two diverging sources of truth.

@garbas garbas self-assigned this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working content
Projects
None yet
Development

No branches or pull requests

3 participants