Skip to content

Commit

Permalink
Merge #201095: edk2-uefi-shell: fix without sandboxing
Browse files Browse the repository at this point in the history
... when built on x86_64-darwin.  Maybe / in some cases, at least.
  • Loading branch information
vcunat committed Nov 18, 2022
2 parents 30eddf1 + 7620992 commit e101394
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkgs/tools/misc/edk2-uefi-shell/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ edk2.mkDerivation "ShellPkg/ShellPkg.dsc" (finalAttrs: {

NIX_CFLAGS_COMPILE = lib.optionals stdenv.cc.isClang [ "-fno-pic" "-Qunused-arguments" ];

# Set explicitly to use Python 3 from nixpkgs. Otherwise, the build system will detect and try to
# use `/usr/bin/python3` on Darwin when sandboxing is disabled.
PYTHON_COMMAND = "${lib.getBin python3}/bin/python3";

# We only have a .efi file in $out which shouldn't be patched or stripped
dontPatchELF = true;
dontStrip = true;
Expand Down

1 comment on commit e101394

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

Please sign in to comment.