-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octoprint fails to build due to recent change in black #165323
Comments
Please just remove black from the test pipeline. There is no reason to run it. |
AFAIK black isn't used in the test pipeline. At least neither click, nor octoprint have black as a build input. |
Black is almost never a runtime dependency. Most of the time it can be safely removed from any requires which safes us the hassle of pinning it or fixing issues. |
We should probably wait for a stable release of octoprint first |
Describe the bug
Due to the update in #157800 which includes psf/black#2791 octoprint fails to build in current unstable release. Octoprint needs a
click
version <8, whereas black now demands a version of >= 8.Steps To Reproduce
Steps to reproduce the behavior:
nix-build -A octoprint https://github.com/nixos/nixpkgs/tarball/nixos-unstable
Expected behavior
octoprint should build.
Error message
Notify maintainers
@abbradar @gebner @WhittlesJr
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.One could add an additional overwrite for black at this point.
On the other hand, octoprint just released its rc2 which drops python2 support and makes a lot of the overwrites unnecessary.
The text was updated successfully, but these errors were encountered: