Upgrade to go 1.18 by default for 22.05

[Mic92]

Describe the bug

Only the last two go releases will receive security updates. Therefore we should at least the latest release to not have an unsupported go version before the next nixos release: https://go.dev/doc/devel/release

[mweinelt]

It can be expected from https://go.dev/doc/devel/release that the next release is due around 2022/08 or 2022/09, so 1.17 will become somewhat problematic in NixOS 22.05.

[zowoq]

#164320

[mweinelt]

I think it's fair to leave this open until the linked PR is actually merged. It will autoclose as soon as it happens, better to track these blockers.

[dasJ]

I'd like to remind the people here that branch-off is scheduled for tomorrow and depending on how good the staging builds progress, we will branch off rather soon.

[mweinelt]

It seems like we'll be heading for a branch-off without this critical separation from the soon to be EOL 1.17 release.

• 1.16 needs to be removed
  • go1.16: remove #168480
• The default needs to migrate to 1.18
  • can someone pick up go, buildGoModule, buildGoPackage: default to 1.18 #164320?

CCing golang team:

• @c00w
• @cstrahan
• @Frostman
• @kalbasit
• @Mic92
• @orivej
• @rvolosatovs
• @zowoq

[Mic92]

Now only the 1.18 is remaining.

[mweinelt]

@Mic92 Do you have any plans to tackle this? I think we can still accept the change until the end of the month.

[mweinelt]

If noone steps up shortly we will most certainly end up with an EOL golang version as the default version mid-release.

[dasJ]

Since this doesn't appear to be solved, does anyone have objections to remove it as a release blocker?

[zowoq]

Done in #179622

[dasJ]

For sake of completeness when somebody stumbles upon this: this PR never went into 22.05