Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune step of npmInstallHook does not remove all unnecessary dependencies when building a workspace package #245115

Open
lilyinstarlight opened this issue Jul 23, 2023 · 0 comments
Open

Prune step of npmInstallHook does not remove all unnecessary dependencies when building a workspace package #245115

lilyinstarlight opened this issue Jul 23, 2023 · 0 comments
Assignees
@lilyinstarlight
Labels
0.kind: bug Something is broken 6.topic: nodejs

Comments

@lilyinstarlight
Copy link
Member

Describe the bug

This was noticed in #218923, but when building a workspace package with buildNpmPackage and there exist dependencies in the top-level packages.json, the npm prune step does not remove those dependencies even when they are unnecessary for the specific workspace being built. This led to the store path increasing in size significantly for the derivation in #218923

I'm not 100% certain if this is a bug or not, but I'm opening an issue here to track my investigation (i.e. so that I can add it to our project board)
@lilyinstarlight lilyinstarlight self-assigned this Jul 23, 2023
@lilyinstarlight lilyinstarlight moved this from Todo to In Progress in Node.js Team Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lilyinstarlight lilyinstarlight

Labels
0.kind: bug Something is broken 6.topic: nodejs
Projects
Node.js Team
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lilyinstarlight