Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snappy does not provide a pkg-config #72179

Closed
lavoiesl opened this issue Oct 28, 2019 · 3 comments · Fixed by #143058
Closed

snappy does not provide a pkg-config #72179

lavoiesl opened this issue Oct 28, 2019 · 3 comments · Fixed by #143058
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action).

Comments

@lavoiesl
Copy link
Contributor

lavoiesl commented Oct 28, 2019

Describe the bug
Because snappy does not install a pkgconfig file, you can't take snappy as a buildInput, packages will never find it.

To Reproduce

$ nix-shell -p snappy snappy.dev
[nix-shell:~]$ pkg-config --debug --libs snappy
Error printing enabled by default due to use of output options besides --exists, --atleast/exact/max-version or --list-all. Value of --silence-errors: 0
Error printing enabled
Adding virtual 'pkg-config' package to list of known packages
Looking for package 'snappy'
Looking for package 'snappy-uninstalled'
Package snappy was not found in the pkg-config search path.
Perhaps you should add the directory containing `snappy.pc'
to the PKG_CONFIG_PATH environment variable
No package 'snappy' found

Expected behavior

$ pkg-config snappy --libs
-L/nix/store/hknzbw87dnmz7zq0lf99vjf7bf2l2hps-snappy-1.1.7/lib -lsnappy
$ pkg-config snappy --cflags
-I/nix/store/z67qhiawswr2jq1p71r4f2987czx3slh-snappy-1.1.7-dev/include

Metadata

  • system: "x86_64-darwin"
  • host os: Darwin 19.0.0, macOS 10.15
  • multi-user?: no
  • sandbox: no
  • version: nix-env (Nix) 2.3.1
  • channels(seb): "nixpkgs-20.03pre197736.91d5b3f07d2"
  • nixpkgs: /Users/seb/.nix-defexpr/channels/nixpkgs

Maintainer information:

attribute: snappy.dev
# a list of nixos modules affected by the problem
module:

cc @wkennington @viric

@lavoiesl lavoiesl added the 0.kind: bug Something is broken label Oct 28, 2019
@lavoiesl
Copy link
Contributor Author

I have opened a PR on the snappy codebase: google/snappy#86

It is waiting for review and then nixpkgs will need to be updated.

Note how the PR has to handle the absolute path being configured in cmake by nix

@veprbl veprbl added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Oct 29, 2019
@lavoiesl
Copy link
Contributor Author

google/snappy#86 has decided not to take the patch upstream, so I will work on adding the pkg-config file as part of the nix installation

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Artturin Artturin closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants