Haskell updates #123682
Merged
Haskell updates #123682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has been generated by maintainers/scripts/haskell/update-stackage.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
|
This PR will only be merged to |
random 1.2.0 has a new test suite with a lot of dependencies. Among other packages it depends on doctest which depends on syb which depends on tasty which depends on optparse-applicative which depends on QuickCheck which depends on -- you guessed it -- random! The cycle could be broken at any point of course, I've disabled the tests on random here because it has seen the change that causes all of this. However, we may also want to consider doing this for optparse-applicative instead, since random seems like a more critical package to run the tests for possibly? Not sure, looking for feedback.
We arrived at 0.14.0.0 naturally via stackage.
hashable's test suite pins random to < 1.2 even in the latest release on hackage, but lifting the bound fixes the build without any issues. Using a patch so we are reminded to remove it when it's unnecessary.
These are not necessary anymore as stackage naturally contains random 1.2.0 and we apply the hashable fix globally as well.
random 1.2.0 is our default version now.
Cabal revisions can break the patches we apply, so we'll need to make any necessary changes to the cabal file with patches ourselves.
We got these cabal file revisions with our hackage update, so we can remove it from the common configuration file.
too strict bound on random
too strict bound on random
…rrent config This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
9 tasks
haskellPackages.nvfetcher: add to top-level
|
The darwin jobs are taking a long time to finish after merging I'll pass off control of this PR to @sternenseemann to start his two weeks 👍 |
| @@ -7138,6 +7138,14 @@ in | |||
|
|
|||
| nvchecker = with python3Packages; toPythonApplication nvchecker; | |||
|
|
|||
| nvfetcher = with haskell.lib; overrideCabal (justStaticExecutables haskellPackages.nvfetcher) (drv: { | |||
| executableToolDepends = [ makeWrapper ]; | |||
| postInstall = '' | |||
There was a problem hiding this comment.
We could move this override to configuration-nix.nix, I think? then haskellPackages.nvfetcher would also be functional were someone to use it.
There was a problem hiding this comment.
I have remarked this in the corresponding PR. berberman said they will improve on this in a future PR they have planned anyways.
Co-authored-by: sterni <[email protected]>
…broken package list
…erging master into haskell-updates
haskell-updates: add documentation for workflow
| as described above. | ||
|
|
||
| - The Haskell team members generally hang out in the Matrix room | ||
| [#haskell-space:matrix.org](https://matrix.to/#/#haskell-space:matrix.org). |
There was a problem hiding this comment.
Shouldn't we link #haskell:nixos.org directly here? My server doesn't support spaces, so I wouldn't be able to get there from the space, I think.
There was a problem hiding this comment.
Whoops, completely pasted the wrong link here.
I've fixed this in 2451208 and changed the link to #haskell:nixos.org. I think that should be correct?
`haskellCompilerName` in cabal2nix and hence ghc 8.10.2 and 8.6.5 "-binary" were not working correctly in this context.
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
haskellPackages.arch-web: unbreak
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Merge
This PR is the regularly merge of the
haskell-updatesbranch intomaster.This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates.
I will aim to merge this PR by 2021-05-28. If I can merge it earlier, there might be successor PRs in that time window. As part of our rotation @sternenseemann will continue these merges from 2021-05-28 to 2021-06-11.
haskellPackages Workflow Summary
Our workflow is currently described at
pkgs/development/haskell-modules/HACKING.md.The short version is this:
haskell-updates(normally at the beginning of a merge window).haskell-updatesintomasterevery two weeks.mergeablejob is succeeding on hydra.This is the follow-up to #122719