Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.nvfetcher: add to top-level #124719

Merged
merged 1 commit into from
May 28, 2021

Conversation

berberman
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build nvfetcher

@cdepillabout
Copy link
Member

This looks good, thanks for adding yourself as maintainer!

@cdepillabout cdepillabout merged commit aa21d85 into NixOS:haskell-updates May 28, 2021
@berberman berberman deleted the nvfetcher branch May 28, 2021 04:26
@maralorn
Copy link
Member

Question: We lately had a trend to move overrides which actually fix packages move into configuration-common.nix. I think that would have been better in this context, too. (Concretely: Have only the justStaticExecutable on the top-level.)
Do we want to continue that? Or are there reasons to keep overrides like this only on the top-level?

@berberman
Copy link
Member Author

Thanks for noting that, the upcoming version requires generateOptparseApplicativeCompletion, and I'll add this new one and move them to configuration-common.nix at once.

@cdepillabout
Copy link
Member

@maralorn Ah, good point. I'll make sure to check for that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants