qemu: fix cross compilation #147692
Merged
qemu: fix cross compilation #147692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphorien
reviewed
Nov 28, 2021
Mindavi
added
the
6.topic: cross-compilation
NickCao
force-pushed
the
qemu
branch
3 times, most recently
from
cba234a
to
8884938
Compare
NickCao
commented
Nov 28, 2021
NickCao
commented
Nov 28, 2021
alyssais
reviewed
Nov 29, 2021
dramforever
added a commit
to dramforever/nixpkgs
that referenced
this pull request
Feb 9, 2023
The python dependencies were fixed for cross in NixOS#147692, but the changes are reversed NixOS#190560 due to concerns of accidentally mixing python versions. Compromise by using python3Packages.python.
dramforever
added a commit
to dramforever/nixpkgs
that referenced
this pull request
Feb 9, 2023
'./configure --cpu=$(uname -m)' (essentially) breaks the case of riscv,
where the configure script expects '--cpu=riscv', but 'uname -m' gives
'riscv{32,64}'. This eventually leads to user-mode emulation being
disabled.
Since the configure script can auto-detect the parameter based on
compilers, remove this flag.
Originally added in NixOS#147692, but apparently it's not needed and @NickCao
couldn't remember why it was added.
13 tasks
dramforever
added a commit
to dramforever/nixpkgs
that referenced
this pull request
Feb 9, 2023
'./configure --cpu=$(uname -m)' (essentially) breaks the case of riscv,
where the configure script expects '--cpu=riscv', but 'uname -m' gives
'riscv{32,64}'. This eventually leads to user-mode emulation being
disabled.
Since the configure script can auto-detect the parameter based on
compilers, remove this flag.
Originally added in NixOS#147692, but apparently it's not needed and @NickCao
couldn't remember why it was added. See also mailing list discussion at
https://lore.kernel.org/qemu-devel/[email protected]/T/
Shawn8901
pushed a commit
to Shawn8901/nixpkgs
that referenced
this pull request
Feb 17, 2023
The python dependencies were fixed for cross in NixOS#147692, but the changes are reversed NixOS#190560 due to concerns of accidentally mixing python versions. Compromise by using python3Packages.python.
Shawn8901
pushed a commit
to Shawn8901/nixpkgs
that referenced
this pull request
Feb 17, 2023
'./configure --cpu=$(uname -m)' (essentially) breaks the case of riscv,
where the configure script expects '--cpu=riscv', but 'uname -m' gives
'riscv{32,64}'. This eventually leads to user-mode emulation being
disabled.
Since the configure script can auto-detect the parameter based on
compilers, remove this flag.
Originally added in NixOS#147692, but apparently it's not needed and @NickCao
couldn't remember why it was added. See also mailing list discussion at
https://lore.kernel.org/qemu-devel/[email protected]/T/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by crossing from x86_64 to riscv64 and x86_64 to x86_64
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes