qemu: riscv related fixes #214534
Merged
qemu: riscv related fixes #214534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some discussion with qemu devs, it seems that the correct thing to do is indeed just not to pass https://lore.kernel.org/qemu-devel/[email protected]/T/ It seems that there is still a bit of problem with regards to cross qemu. I'll come back to it once I get that settled. |
The python dependencies were fixed for cross in NixOS#147692, but the changes are reversed NixOS#190560 due to concerns of accidentally mixing python versions. Compromise by using python3Packages.python.
dramforever
force-pushed
the
qemu-remove-cpu-flag
branch
from
12d895e
to
e947b2f
Compare
|
cc @figsoda @SuperSandro2000 from #190560 and @NickCao from #147692 |
'./configure --cpu=$(uname -m)' (essentially) breaks the case of riscv,
where the configure script expects '--cpu=riscv', but 'uname -m' gives
'riscv{32,64}'. This eventually leads to user-mode emulation being
disabled.
Since the configure script can auto-detect the parameter based on
compilers, remove this flag.
Originally added in NixOS#147692, but apparently it's not needed and @NickCao
couldn't remember why it was added. See also mailing list discussion at
https://lore.kernel.org/qemu-devel/[email protected]/T/
|
the python change lgtm, don't know enough to review the change to |
dramforever
force-pushed
the
qemu-remove-cpu-flag
branch
from
e947b2f
to
08e6d08
Compare
|
Had to disable sdl support to test due to dependency failure. Builds fine crossing from x86_64-linux to riscv64-linux, build/host platform is correctly recognized by build system, qemu-user support is discovered and built. |
NickCao
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes found when trying to use qemu on riscv.
Description of changes
Things done
sdlSupport = false)sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes