gitea: Fix postPatch command; add coreutils to PATH #236700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command is needed to substitute @DaTa@ which is added by static-root-path.patch. When this patch was rebased for 1.19.0, the file name changed, but the command was not updated.
coreutils is used by hooks which are generated by gitea, e.g.: $ cat hooks/pre-receive #!/usr/bin/env bash # AUTO GENERATED BY GITEA, DO NOT MODIFY data=$(cat) exitcodes="" hookname=$(basename $0)
Ma27
approved these changes
Jun 9, 2023
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed substitution of wrong file in
postPatchphase. This command is needed to substitute@data@which is added bystatic-root-path.patch. When that patch was rebased for 1.19.0 in 5c5f710, the file name changed fromsetting.gotoserver.go, but the command was not updated. So I was not able to start gitea without settingSTATIC_ROOT_PATHin my config file explicitly.Added coreutils to
PATHexplicitly. Coreutils is used in git hooks generated by gitea, e.g. here, and if you omit coreutils and it's not present in defaultPATH, you get these errors when doinggit push:Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)