minosoft: init at 7ba4569 #244566
minosoft: init at 7ba4569 #244566
Conversation
|
|
||
| let | ||
| pname = "minosoft"; | ||
| version = "7ba4569"; # there are no tags yet, so lets version this using tags for now |
There was a problem hiding this comment.
In such case, you must use
| version = "7ba4569"; # there are no tags yet, so lets version this using tags for now | |
| version = "unstable-YYYY-MM-DD"; |
where the YYYY-MM-DD is the date of the commit you are picking.
| buildPhase = '' | ||
| export GRADLE_USER_HOME=$(mktemp -d) | ||
| # https://github.com/gradle/gradle/issues/4426 | ||
| ${lib.optionalString stdenv.isDarwin "export TERM=dumb"} |
There was a problem hiding this comment.
Can this be set unconditionally?
There was a problem hiding this comment.
Will evaluate what makes more sense.
|
|
||
| nativeBuildInputs = [ gradle perl makeWrapper copyDesktopItems ]; | ||
|
|
||
| desktopItems = [ desktopItem ]; |
There was a problem hiding this comment.
Write the desktopItem directly here.
| maintainers = with maintainers; [ aprl ]; | ||
| platforms = platforms.all; | ||
| # https://github.com/NixOS/nixpkgs/pull/99885#issuecomment-740065005 | ||
| #broken = stdenv.isDarwin; |
Co-authored-by: Anderson Torres <[email protected]>
Co-authored-by: Anderson Torres <[email protected]>
|
Note for future reviewers: This PR is not ready yet, as why its marked WIP. There is currently a issue with the gradle deps not working correctly because of some issues with the perl script. Currently evaluating on a better way to replace the old perl script from Minestom and replacing it either with a updated version of the old gradle2nix which got abandoned, or a even newer way of a new and improved script for the current perl hack |
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
|
#272380 got merged, so you can give this a second shot now! See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md |
stale
bot
removed
the
2.status: stale
Description of changes
From the project's GitLab: "Minosoft is an open source minecraft client, written from scratch in kotlin (and java). It aims to bring more functionality and stability."
Resolves #237956
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)