Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidermonkey_91: fix build with python311 #264204

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

devusb
Copy link
Contributor

@devusb devusb commented Oct 29, 2023

Description of changes

The recent change of python3 to be python311 breaks the build of spidermonkey_91 due to its use of a deprecated file mode. Although spidermonkey_91 is EOL, it's still required by couchdb3 -- this PR adds a patch borrowed from Fedora to fix the file modes and allow building with python311.

ZHF: #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@devusb devusb changed the title spidermonkey_91: add patch to allow building with python311 spidermonkey_91: fix build with python311 Oct 29, 2023
@devusb
Copy link
Contributor Author

devusb commented Oct 29, 2023

Result of nixpkgs-review pr 264204 run on x86_64-linux 1

3 packages built:
  • couchdb3
  • spidermonkey_91
  • spidermonkey_91.dev

@marius851000
Copy link
Contributor

Tested it. Couchdb compile again.

@devusb
Copy link
Contributor Author

devusb commented Nov 1, 2023

@marius851000 mind marking with an approve if it worked for you?

@marius851000
Copy link
Contributor

Approval? Doesn't that require some specific permission that I don't have?

@devusb devusb added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 7, 2023
@mweinelt mweinelt merged commit 6f25835 into NixOS:master Nov 7, 2023
29 checks passed
@devusb devusb deleted the spidermonkey branch November 7, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants