Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: avoid using unspliced dependency #265162

Closed
wants to merge 3 commits into from
Closed

bash: avoid using unspliced dependency #265162

wants to merge 3 commits into from

Commits on Nov 3, 2023

  1. lib.systems, test.cross.sanity: add test case for #264989 

    We have several cross-compilation bugs that show up if
hostPlatform!=buildPlatform yet
hostPlatform.config==buildPlatform.config.

These bugs have appeared and disappeared as we've fiddled with the
definition of equality for platform objects.  This commit adds a
clear-cut case where they are *not* equal and never will be, so we
can test it.
    Adam Joseph committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a7d0caa View commit details
    Browse the repository at this point in the history

  2. gcc.libgcc: compare host and target platforms, rathern than their tri… 

    …ples

The rest of our gcc expression prepends "${targetPlatform.config}-"
to paths and binaries if `hostPlatform!=targetPlatform`.  The
`libgcc.nix` expression was using
'hostPlatform.config!=targetPlatform.config`, which caused it to
look in the wrong place when moving files.  This commit corrects that.
    Adam Joseph committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8408127 View commit details
    Browse the repository at this point in the history

  3. bash: avoid using unspliced dependency 

    `stdenv` is spliced, but `stdenv.cc` is not, so we can't use the
latter in dependencies.

Closes #264989
Closes #243164
    Adam Joseph committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    667a1ad View commit details
    Browse the repository at this point in the history