Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: do not use unspliced dependency #265759

Closed
wants to merge 1 commit into from
Closed

ncurses: do not use unspliced dependency #265759

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2023

Description of changes

ncurses uses an unspliced dependency; this prevents pkgsCross.gnu64_simplekernel.mesa from building correctly even with #233628

Once #263082 is merged we will get warnings for this and they won't pop up like surprises.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Nov 6, 2023
12 tasks
@ghost ghost changed the base branch from master to staging November 6, 2023 01:02
@alyssais
Copy link
Member

alyssais commented Nov 6, 2023

Is this a duplicate of #265060?

@ghost
Copy link
Author

ghost commented Nov 6, 2023

Is this a duplicate of #265060?

On closer inspection that is a better approach.

@ghost ghost closed this Nov 6, 2023
@ghost ghost deleted the ncurses-unspliced-dependency branch January 23, 2024 06:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant