Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbrf: fix build #266190

Closed
wants to merge 1 commit into from
Closed

openbrf: fix build #266190

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2023

Description of changes

ZHF: #265948
https://hydra.nixos.org/build/239129983

use version 1.0.1 of c++ template library vcg package (2016). nixpkgs updated vcg package this year and broke openbrf. openbrf has not seen any modifications since 2016.

openbrf
vcglib

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Nov 8, 2023

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • openbrf

@ghost ghost requested a review from abbradar November 8, 2023 05:44
@ghost ghost added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 8, 2023
@wamserma
Copy link
Member

wamserma commented Nov 8, 2023

Result of nixpkgs-review pr 266190 run on aarch64-linux 1

1 package built:
  • openbrf

use old vcglib
@ghost ghost closed this Nov 10, 2023
@ghost ghost deleted the openbrf-fix branch November 10, 2023 19:09
@pbsds
Copy link
Member

pbsds commented Nov 10, 2023

Sad to see you close this, i liked your fix. Sorry if i'm being too nitty. Would you mind if i opened a new PR with your fix, tagging you as author?

@ghost
Copy link
Author

ghost commented Nov 10, 2023

Sad to see you close this, i liked your fix. Sorry if i'm being too nitty. Would you mind if i opened a new PR with your fix, tagging you as co-author?

yeah- i shouldn't have closed it. sorry about that. it just seems the comments are now beyond the lines of code changed.

@ghost ghost restored the openbrf-fix branch November 10, 2023 19:26
@ghost ghost reopened this Nov 10, 2023
@ghost
Copy link
Author

ghost commented Nov 10, 2023

Sad to see you close this, i liked your fix. Sorry if i'm being too nitty. Would you mind if i opened a new PR with your fix, tagging you as author?

feel free to take the code and make changes. i do not need any co-author credit.

i just pushed the prior version, which you can find here:
https://github.com/robert-manchester/nixpkgs/pull/new/openbrf-fix-newvcg

@pbsds pbsds mentioned this pull request Nov 10, 2023
13 tasks
@ghost
Copy link
Author

ghost commented Nov 10, 2023

closing due to differing opinions

@ghost ghost closed this Nov 10, 2023
@ghost ghost deleted the openbrf-fix branch November 10, 2023 21:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants