-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbrf: fix build #266190
openbrf: fix build #266190
Conversation
Result of 1 package built:
|
Result of 1 package built:
|
use old vcglib
Sad to see you close this, i liked your fix. Sorry if i'm being too nitty. Would you mind if i opened a new PR with your fix, tagging you as author? |
yeah- i shouldn't have closed it. sorry about that. it just seems the comments are now beyond the lines of code changed. |
feel free to take the code and make changes. i do not need any co-author credit. i just pushed the prior version, which you can find here: |
closing due to differing opinions |
Description of changes
ZHF: #265948
https://hydra.nixos.org/build/239129983
use version 1.0.1 of c++ template library vcg package (2016). nixpkgs updated vcg package this year and broke openbrf. openbrf has not seen any modifications since 2016.
openbrf
vcglib
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)