Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persepolis,qnotero: mark broken on Darwin for ZHF #266670

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Nov 10, 2023

Description of changes

I found these while working on resolving build failures during a nixpkgs-review for fixes for staging-next #263535. While it might be possible to make these build, it would require non-trivial changes to their build scripts. Mark them broken for ZHF.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode reckenrode changed the title persepolis,qnotero: mark broken on Darwin persepolis,qnotero: mark broken on Darwin for ZHF Nov 10, 2023
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 10, 2023
@wegank wegank merged commit 982816e into NixOS:master Nov 10, 2023
24 of 26 checks passed
@pbsds
Copy link
Member

pbsds commented Nov 10, 2023

Is it common to mark packages broken this early in ZHF?

@wegank
Copy link
Member

wegank commented Nov 10, 2023

I'd say these are leftovers from the last ZHF and should have been marked as broken five months ago.

And I am indeed surprised that there's a PR fixing one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants