Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playwright: 1.38.0 -> 1.40.0 #269658

Merged
merged 1 commit into from
Nov 29, 2023
Merged

playwright: 1.38.0 -> 1.40.0 #269658

merged 1 commit into from
Nov 29, 2023

Conversation

phaer
Copy link
Member

@phaer phaer commented Nov 24, 2023

Description of changes

https://github.com/microsoft/playwright/releases/tag/v1.40.0
https://github.com/microsoft/playwright/releases/tag/v1.39.0
https://github.com/microsoft/playwright/releases/tag/v1.38.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@nopnop
Copy link

nopnop commented Nov 24, 2023

Thanks a lot @phaer
We tested it with success on our e2e suite.

@phaer phaer marked this pull request as draft November 28, 2023 14:40
@phaer phaer force-pushed the playwright-upgrade branch 2 times, most recently from bab8382 to f571ee9 Compare November 28, 2023 15:12
@phaer phaer marked this pull request as ready for review November 28, 2023 15:13
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3002

@phaer
Copy link
Member Author

phaer commented Nov 28, 2023

Note to self: setuptools-scm hack can be removed after #229460 (review) gets merged

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1263

@mweinelt mweinelt merged commit 76f642f into NixOS:master Nov 29, 2023
21 of 22 checks passed
@phaer phaer deleted the playwright-upgrade branch November 29, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants