python3Packages.chia-rs: fix dependency patch and add missing check inputs

[mfrischknecht]

The build for chia-rs is broken because the fix-build.patch
file doesn't apply to the currently packaged source version.
Since the patch changes the dependencies pulled into the module's
rust build, I also had to change the corresponding Cargo.lock
file override.

With the fixed build, the module's tests also fail because of two
missing dependencies (clvm, clvm_tools).

Things done

• Adapted fix-build.patch for the currently packaged version
• Added clvm and clvm-tools dependencies as check inputs

Hydra job: https://hydra.nixos.org/build/241321128#tabs-details
Hydra build: https://hydra.nixos.org/build/241321128/nixlog/3

Relevant log excerpt:

patching sources
applying patch /nix/store/61vqx009qlkk0hh150n623mjcfg14dd7-fix-build.patch
patching file Cargo.toml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Cargo.toml.rej

#ZurichZHF

ZHF: #265948

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[delroth]

@ofborg build python3Packages.chia-rs

[delroth]

This PR seems generally fine. Had to dig up through some history to figure out why this Cargo.lock vendoring is required - looks like upstream disabled building the wheel subdir by default, which means their lockfile doesn't include the deps for it.

Given that this package seems to be unmaintained, I question whether it should be kept in the package set. It keeps being broken, the maintainer team seems mostly inactive and other members of the community are having to step up to keep it up to date and building.

@lourkeur can you commit to keeping this up to date and unbroken in the future, or should we remove this derivation from nixpkgs?

[bbjubjub2494]

This PR seems generally fine. Had to dig up through some history to figure out why this Cargo.lock vendoring is required - looks like upstream disabled building the wheel subdir by default, which means their lockfile doesn't include the deps for it.

Given that this package seems to be unmaintained, I question whether it should be kept in the package set. It keeps being broken, the maintainer team seems mostly inactive and other members of the community are having to step up to keep it up to date and building.

@lourkeur can you commit to keeping this up to date and unbroken in the future, or should we remove this derivation from nixpkgs?

I cannot commit, please see #270254

[delroth]

Thank you for the quick reply! Let's close this in favor of #270254 then.