Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.yamlpath: mark as broken #270193

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

mfrischknecht
Copy link
Contributor

yamlpath depends on ruamel.yaml <= 0.17.21 1, but the packaged version in Nixpkgs is on version 0.17.32 by now. This breaks a lot of the libraries own unit tests.

As I don't see anything in Nixpkgs depending on yamlpath, this simply marks the package as broken.

Description of changes

Mark the package as broken.

#ZurichZHF

ZHF: #265948

Hydra build: https://hydra.nixos.org/build/241253815#tabs-summary
Hydra logs: https://hydra.nixos.org/build/241253815/nixlog/1

Various tests fail like this:

>           assert result.success, result.stderr
E           AssertionError: Traceback (most recent call last):
E               File "/nix/store/8wmyl8bxwridjxvzy7r7ygn77skm6wrc-python3.11-pytest-console-scripts-1.4.1/lib/python3.11/site-packages/pytest_console_scripts/__init__.py", line 310, in console_script
E                 return s()
E                        ^^^
E               File "/build/source/yamlpath/commands/yaml_merge.py", line 548, in main
E                 exit_state = merge_condense_all(log, mergers, [])
E                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E               File "/build/source/yamlpath/commands/yaml_merge.py", line 394, in merge_condense_all
E                 lhs_prime.merge_with(lhs_doc.data)
E               File "/build/source/yamlpath/merger/merger.py", line 865, in merge_with
E                 merge_performed = self._insert_dict(
E                                   ^^^^^^^^^^^^^^^^^^
E               File "/build/source/yamlpath/merger/merger.py", line 657, in _insert_dict
E                 merged_data = self._merge_dicts(lhs, rhs, insert_at)
E                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E               File "/build/source/yamlpath/merger/merger.py", line 225, in _merge_dicts
E                 lhs[key].yaml_set_tag(val.tag.value)
E                 ^^^^^^^^^^^^^^^^^^^^^
E             AttributeError: 'CommentedSeq' object has no attribute 'yaml_set_tag'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

`yamlpath` depends on `ruamel.yaml` <= 0.17.21 [1], but the packaged
version in Nixpkgs is on version 0.17.32 by now. This breaks a lot
of the libraries own unit tests.

As I don't see anything in Nixpkgs depending on `yamlpath`, this simply
marks the package as broken.

[1]: https://github.com/wwkimball/yamlpath/blob/9bbddea5205147d49e612abb26cf1671a3861256/setup.py#L48
@mfrischknecht
Copy link
Contributor Author

mfrischknecht commented Nov 26, 2023

@Flakebi: Since you are listed as the maintainer of this package:

@Nebucatnetzer proved on his local machine that these errors could be fixed if we would downgrade the ruamel.yaml dependency by overriding its version and fetching hash in the Nix package definition. We discussed this approach with @delroth, but it didn't seem worth the packaging headache to us. But if you're interested in doing so, that would also be an option.

@delroth delroth requested a review from Flakebi November 26, 2023 21:30
@delroth
Copy link
Contributor

delroth commented Nov 26, 2023

Oh, actually I just saw that @Flakebi +1'd the PR. I'll take that as an approval :-)

@delroth delroth added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-23.11 labels Nov 26, 2023
@delroth delroth merged commit d9b8524 into NixOS:master Nov 26, 2023
8 of 9 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Copy link
Contributor

Git push to origin failed for release-23.11 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants