Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.gentools: switch to pyproject; fix build #270590

Merged
merged 3 commits into from Nov 28, 2023
Merged

python311Packages.gentools: switch to pyproject; fix build #270590

merged 3 commits into from Nov 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2023 •
edited by ghost
Loading

build broken due to missing setup.py. switch to pyproject, add missing build dependency poetry-core, prefer pytestCheckHook over pytest, add pythonImportCheck.

ZHF: #265948
https://hydra.nixos.org/build/241256836

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • python310Packages.gentools
  • python310Packages.gentools.dist
  • python311Packages.gentools
  • python311Packages.gentools.dist

Result of nixpkgs-review run on x86_64-darwin 1

4 packages built:
  • python310Packages.gentools
  • python310Packages.gentools.dist
  • python311Packages.gentools
  • python311Packages.gentools.dist

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@ghost ghost added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 28, 2023
@github-actions github-actions bot added 6.topic: python and removed 0.kind: ZHF Fixes Fixes during the ZHF campaign labels Nov 28, 2023
@fabaff
Copy link
Member

fabaff commented Nov 28, 2023

Result of nixpkgs-review pr 270590 run on x86_64-linux 1

4 packages built:
  • python310Packages.gentools
  • python310Packages.gentools.dist
  • python311Packages.gentools
  • python311Packages.gentools.dist

fabaff
fabaff approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@ghost
Copy link
Author

ghost commented Nov 28, 2023

Change looks good to me.

thanks for the additional cleanups!

@ghost ghost added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 28, 2023
@ofborg ofborg bot requested a review from mredaelli November 28, 2023 12:13
@fabaff fabaff merged commit be5c9c1 into NixOS:master Nov 28, 2023
26 of 27 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
1 task
@ghost ghost deleted the gentools-pyproject branch November 29, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mredaelli mredaelli Awaiting requested review from mredaelli

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @delroth