Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.setuptools-scm: 7.1.0 -> 8.0.4 #270682

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

phaer
Copy link
Member

@phaer phaer commented Nov 28, 2023

Description of changes

https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md#v804

fixes #264820

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@phaer
Copy link
Member Author

phaer commented Nov 28, 2023

Oh wow, I had expected quite some rebuilds - hence targeting staging - but with that amount we might want to wait for another python-update cycle?

@NickCao
Copy link
Member

NickCao commented Nov 29, 2023

Oh wow, I had expected quite some rebuilds - hence targeting staging - but with that amount we might want to wait for another python-update cycle?

cc @mweinelt

@mweinelt
Copy link
Member

mweinelt commented Nov 29, 2023

Yes, it's going to have to be a python-updates cycle. One is already forming up with #270457.

@phaer phaer mentioned this pull request Dec 1, 2023
13 tasks
@mweinelt mweinelt marked this pull request as draft December 2, 2023 02:35
@mweinelt mweinelt changed the base branch from staging to python-updates December 2, 2023 02:36
@mweinelt mweinelt marked this pull request as ready for review December 2, 2023 02:37
@mweinelt mweinelt merged commit 28192ad into NixOS:python-updates Dec 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants