spooles: fix compiler errors and link properly; fix darwin build #270901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
0.kind: ZHF Fixes
fix a few format string errors and use the proper type, 0, not NULL, to specify zero as a function parameter.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3017 |
risicle
approved these changes
Dec 1, 2023
Merged
1 task
|
Successfully created backport PR for |
ghost
deleted the
|
thanks for all the ZHF reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a few format string errors and use the proper type, 0, not NULL, to specify zero as a function parameter. after the fixes, the calculix program, which links to libspooles, runs on darwin (and produces valid output).
testing: ran some of the calculix examples linked off of http://www.dhondt.de/ and verified that the output matches the references output on both x64 linux and x64 darwin
ZHF: #265948
https://hydra.nixos.org/build/241160456
Result of
nixpkgs-review pr 270901run on x86_64-linux 12 packages built:
Result of
nixpkgs-review pr 270901run on x86_64-darwin 12 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.