Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger-control: unstable-2023-06-18 -> 1.5.1 #271340

Merged
merged 1 commit into from
Dec 1, 2023
Merged

trigger-control: unstable-2023-06-18 -> 1.5.1 #271340

merged 1 commit into from
Dec 1, 2023

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Dec 1, 2023

Description of changes

Changelog https://github.com/Etaash-mathamsetty/trigger-control/releases

Also fix build on darwin/clang, ZHF #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@azuwis
trigger-control: unstable-2023-06-18 -> 1.5.1
be94fe0 
Also fix build on darwin/clang
@emilytrau emilytrau added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-23.11 labels Dec 1, 2023
@azuwis azuwis force-pushed the trigger-control branch 2 times, most recently from 3c6bb30 to b1513da Compare December 1, 2023 04:55
ghost
ghost approved these changes Dec 1, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i don't have a controller to test but change looks fine.

Result of nixpkgs-review pr 271340 run on x86_64-linux 1

1 package built:
  • trigger-control

Result of nixpkgs-review pr 271340 run on x86_64-darwin 1

1 package built:
  • trigger-control

@emilytrau emilytrau merged commit 4052ea5 into NixOS:master Dec 1, 2023
29 checks passed
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Successfully created backport PR for release-23.11:

@bjornfor bjornfor mentioned this pull request Dec 17, 2023
Closed
13 tasks
@azuwis azuwis deleted the trigger-control branch December 20, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy kirillrdy left review comments

@wegank wegank wegank approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azuwis @kirillrdy @wegank @delroth @emilytrau