cudaPackages: replace the FHS paths in pkg-config files #275921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidalgol
approved these changes
Dec 22, 2023
aidalgol
approved these changes
Dec 22, 2023
SomeoneSerge
force-pushed
the
fix/cuda-pkg-config
branch
from
3fbafef
to
684ca4d
Compare
|
(squashed the fixup) Thanks @aidalgol! I think we still need to run the builds to see that e.g. the FHS scan didn't break any more packages |
samuela
reviewed
Dec 22, 2023
aidalgol
approved these changes
Dec 24, 2023
SomeoneSerge
force-pushed
the
fix/cuda-pkg-config
branch
from
684ca4d
to
cfa0701
Compare
|
Result of 41 packages marked as broken and skipped:
37 packages failed to build:
71 packages built:
Logs: https://gist.github.com/SomeoneSerge/cf6f131abb2f71f55996dc86104edbc6 Most of these fail with "Detected references to /usr" so I'm going to make |
...harden gradually instead
aidalgol
approved these changes
Dec 25, 2023
|
Result of 41 packages marked as broken and skipped:
8 packages failed to build:
100 packages built:
Logs: https://gist.github.com/SomeoneSerge/58537247af3cabcffb57465005497f65
Neither are related to this PR |
SomeoneSerge
commented
Jan 9, 2024
Comment on lines
+125
to
+129
| if [[ -d pkg-config ]] ; then | ||
| mkdir -p share/pkg-config | ||
| mv pkg-config/* share/pkg-config/ | ||
| rmdir pkg-config | ||
| fi |
There was a problem hiding this comment.
nixpkgs/pkgs/build-support/pkg-config-wrapper/setup-hook.sh
Lines 15 to 18 in 9be1431
🤦🏻 🤦🏻 🤦🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #224119
@NixOS/cuda-maintainers
Description of changes
libdir = /usr/local/whateverwithlibdir = ${!outputLib}, etcThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.