Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.{repa,hip}: Apply build fixes #276275

Closed
wants to merge 9 commits into from

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Dec 23, 2023

This PR is for merging into #279413, cc @sternenseemann.

Description of changes

One does not simply import Graphics.Image.Processing.

This fixes the build of the hip package under ghc94, ghc96, ghc98. Because repa is a dependency, that also gets a patch so that it builds.

Things done

nix build --system x86_64-linux .#haskell.packages.ghc9{4,6,8}.{hip,repa-{io,algorithms}}

I haven't opened upstream issues/PRs yet.

@maralorn
Copy link
Member

maralorn commented Jan 1, 2024

Can we maybe do this via the "inherit trick" so that Nix does not silently override potential other repa overrides in the file?

@rvl
Copy link
Contributor Author

rvl commented Jan 10, 2024

Can we maybe do this via the "inherit trick"

Yes, good idea @maralorn. I have updated the patch.

@domenkozar
Copy link
Member

ping

@maralorn
Copy link
Member

@domenkozar Who are you pinging and why?

@rvl
Copy link
Contributor Author

rvl commented Jan 11, 2024

pong 🙂

@rvl
Copy link
Contributor Author

rvl commented Jan 11, 2024

I quoted the wrong PR number in the description, that's why.

Some dependencies of Chart-diagrams have been updated and no longer
require Cabal jailbreaks.

Of the remaining jailbreaks, I have added links to GitHub issues/PRs,
where they exist.
@sternenseemann
Copy link
Member

Cherry-picked onto haskell-updates with some minor changes.

@rvl
Copy link
Contributor Author

rvl commented Jan 11, 2024

Thanks @sternenseemann 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants