libtiff: Add patch to fix missing Lerc in libtiff-4.pc

[nh2]

Description of changes

Found in static-haskell-nix. This should help pkgsStatic equally.

Upstream PR is: https://gitlab.com/libtiff/libtiff/-/merge_requests/633

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

@NixOS/geospatial

[l0b0]

Code LGTM; thank you for the thorough work! Some caveats/questions:

• The patch hasn't been accepted upstream yet. It might be prudent to wait for that to happen before adding it.
• Which situation does this fix in nixpkgs? Is Lerc in nixpkgs' libtiff already not working? (If so, which commit broke it?) Another way to think about it is: would it be possible to add a test for this to demonstrate what the patch fixes?
• Does this remove the need for lerc in buildInputs? Is it equivalent? Complementary? Or just not related to that line?
• We'll probably want a "TODO" comment marking this for git revert once the upstream patch is in the latest release of libtiff.

[nh2]

This was accidentally closed by nh2/static-haskell-nix@4c9cf63

with my commit message

nixpkgs: Update submodule to include libtiff fix

https://github.com/NixOS/nixpkgs/pull/320105

Looks like Github is way too agressive, parsing that as fixes https://github.com/NixOS/nixpkgs/pull/320105...

Reopening.

[nh2]

• The patch hasn't been accepted upstream yet. It might be prudent to wait for that to happen before adding it.

Maybe for a while, yes.

It's quite certainly correct to do this, as libtiff's other build system (CMake instead of autoconf) does this as well.

I believe the only reason it isn't in their autoconf build system is that either they forgot it, or because in contrast to CMake, autoconf cannot check for the version number in which Lerc has a .pc file.

• Which situation does this fix in nixpkgs? Is Lerc in nixpkgs' libtiff already not working?

This fixes pkgsStatic.libwebp.

In normal pkgs, it's already working; only fixes static builds.

• Does this remove the need for lerc in buildInputs? Is it equivalent? Complementary? Or just not related to that line?

Unrelated to that line; lerc is still a dependency of libtiff.

• We'll probably want a "TODO" comment marking this for git revert once the upstream patch is in the latest release of libtiff.

Done.

[imincik]

Looks good to me. Thanks for this fix @nh2