Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra: 11.1.1 -> 11.1.2, upgrade to gradle 8, openjdk 21 #326303

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Jul 11, 2024

Description of changes

Updates Ghidra from 11.1.1 to 11.1.2. Also, upgrades Ghidra to build and run with Gradle 8 and OpenJDK 21 to match the upstream.

Tested basic functionality on x86-64_linux.

Ghidraninja scripts needs binwalk. With #326295 applied it seems to compile and load up fine. Other plugins are working inside just this PR.

Tested basic functionality on aarch64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jchv
Copy link
Contributor Author

jchv commented Jul 11, 2024

Result of nixpkgs-review pr 326303 run on x86_64-linux 1

4 packages built:
  • ghidra
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@jchv
Copy link
Contributor Author

jchv commented Jul 11, 2024

Result of nixpkgs-review pr 326303 run on aarch64-darwin 1

4 packages built:
  • ghidra
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Rebased since #272380 finally landed :)

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Result of nixpkgs-review pr 326303 run on x86_64-linux 1

5 packages built:
  • ghidra
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Result of nixpkgs-review pr 326303 run on aarch64-darwin 1

5 packages built:
  • ghidra
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4263

@SuperSandro2000 SuperSandro2000 merged commit 7a4f677 into NixOS:master Jul 17, 2024
29 of 30 checks passed
@jchv jchv deleted the update/ghidra branch September 27, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants