gradle: fix update-deps.sh to use Nix bash #329272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayleaf
reviewed
Jul 23, 2024
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
3067b1e
to
c6222b6
Compare
|
Nit is addressed :) Thanks for the review |
|
Result of 1 package failed to build:
2 packages built:
|
chayleaf
reviewed
Jul 23, 2024
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
c6222b6
to
2f2724e
Compare
chayleaf
reviewed
Jul 29, 2024
pkgs/tools/security/ghidra/extensions/gnudisassembler/default.nix
Outdated
Show resolved
Hide resolved
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
2f2724e
to
c526be6
Compare
|
Result of 1 package failed to build:
2 packages built:
|
chayleaf
reviewed
Jul 29, 2024
pkgs/tools/security/ghidra/extensions/gnudisassembler/default.nix
Outdated
Show resolved
Hide resolved
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
c526be6
to
ab8a524
Compare
|
|
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
ab8a524
to
6e7ba87
Compare
13 tasks
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
6e7ba87
to
d61380e
Compare
emilytrau
reviewed
Aug 2, 2024
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
d61380e
to
aac69e0
Compare
This fixes an issue on non NixOS Linux distributions where their system bash might be outside of /tmp, /nix, and /run. Thanks to @puckipedia for the suggestion
This is required as Ghidra plugins don't have a consistent layout and have to be widely configurable
vringar
force-pushed
the
fix/ghidra-extensions
branch
from
aac69e0
to
5c354f1
Compare
emilytrau
changed the title
|
Result of 3 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes two issues I had with the gradle refactor and my external Ghidra plugins.
Things done
I only checked that this works for my specific use case. I didn't update all Gradle packages to see if this change somehow breaks something.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.