Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] nixVersions: backport 2.24.3 as nixVersions.latest #336108

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

With #335342 incoming on master, it's really awkward to have the stable version on master not be available on the latest release branch.

See for instance zhaofengli/attic#159.

This PR cherry-picks commits from #331720, #333183, #333986, #336076, and #332724 so that nixVersions.latest is 2.24.3.

I think this is the minimal set to backport.

Result of nixpkgs-review run on x86_64-linux 1

16 packages built:
  • nil
  • nixVersions.git
  • nixVersions.git.debug
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man
  • nixVersions.nix_2_22
  • nixVersions.nix_2_22.debug
  • nixVersions.nix_2_22.dev
  • nixVersions.nix_2_22.doc
  • nixVersions.nix_2_22.man

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 20, 2024

I had #335532 opened.

@philiptaron
Copy link
Contributor Author

Apologies for the overlap, @Mic92!

@Mic92
Copy link
Member

Mic92 commented Aug 20, 2024

This one is more up-to-date.

@Mic92
Copy link
Member

Mic92 commented Aug 21, 2024

Result of nixpkgs-review pr 336108 run on x86_64-linux 1

16 packages built:
  • nil
  • nixVersions.git
  • nixVersions.git.debug
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man
  • nixVersions.nix_2_22
  • nixVersions.nix_2_22.debug
  • nixVersions.nix_2_22.dev
  • nixVersions.nix_2_22.doc
  • nixVersions.nix_2_22.man

@Mic92
Copy link
Member

Mic92 commented Aug 21, 2024

Result of nixpkgs-review pr 336108 run on aarch64-linux 1

16 packages built:
  • nil
  • nixVersions.git
  • nixVersions.git.debug
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man
  • nixVersions.nix_2_22
  • nixVersions.nix_2_22.debug
  • nixVersions.nix_2_22.dev
  • nixVersions.nix_2_22.doc
  • nixVersions.nix_2_22.man

@Mic92 Mic92 merged commit 1bee20d into NixOS:release-24.05 Aug 21, 2024
26 of 28 checks passed
@Mic92
Copy link
Member

Mic92 commented Aug 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants