-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.05] nixVersions: backport 2.24.3 as nixVersions.latest #336108
Merged
Mic92
merged 6 commits into
NixOS:release-24.05
from
philiptaron:backport-nix-2.24-to-24.05
Aug 21, 2024
Merged
[Backport release-24.05] nixVersions: backport 2.24.3 as nixVersions.latest #336108
Mic92
merged 6 commits into
NixOS:release-24.05
from
philiptaron:backport-nix-2.24-to-24.05
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal of the update is to get past the possible upstream fix for NixOS/nix#11265
I had #335532 opened. |
Apologies for the overlap, @Mic92! |
This one is more up-to-date. |
ofborg
bot
requested review from
Artturin,
oxalica,
figsoda,
edolstra and
lovesegfault
August 20, 2024 17:48
Result of 16 packages built:
|
Result of 16 packages built:
|
Thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With #335342 incoming on master, it's really awkward to have the stable version on master not be available on the latest release branch.
See for instance zhaofengli/attic#159.
This PR cherry-picks commits from #331720, #333183, #333986, #336076, and #332724 so that
nixVersions.latest
is 2.24.3.I think this is the minimal set to backport.
Result of
nixpkgs-review
run on x86_64-linux 116 packages built:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)