-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesa: restructure driver selection to be more architecture-neutral #45474
Conversation
This allows Mesa to also build on ppc64le.
I don't see this very readable. What you could do is just a separate case for x86 and then an else case which just adds the safest option (which is presumably only |
The point was that "generic" architectures (like Power) that have PCIe support but no integrated GPUs get all drivers for GPUs widely available as PCIe cards by default, while drivers for integrated GPUs are only built for their platforms (ARM ⇒ freedreno, etnaviv, x86 ⇒ Intel drivers), so when following your suggestion I would need to add a specific path for ppc64(le) for each variable … |
Makes sense. Maybe have the |
Note that adding support for a new platform is something that should go through the RFC process (since it may introduce a non-trivial maintenance burden for other contributors). |
New design that more clearly shows the reasoning. |
@edolstra Where can I access that process? FWIW, the initial platform enablement PR was marked as [RFC] … |
I see discussion on NixOS/rfcs#31 has largely concluded without major unaddressed objections … |
I still think this is helpful - the old way basically just had static lists for each system. We should think more in capabilities - what driver works and doesn't work with each system. |
@GrahamcOfBorg build mesa |
Motivation for this change
Allows Mesa to build on non-x86, non-ARM platforms like ppc64(le).
Part of my roadmap to bring NixOS to OpenPower platforms.
The new logic should be logically equivalent for x86 and ARM platforms (but might cause rebuilds due to reordered list elements).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)