-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blas/Lapack cross fixes #92412
Blas/Lapack cross fixes #92412
Conversation
We need to set FC so that CMake and other tools can find the fortran compiler. Also we need to limit the hardening flags since fortify and format don’t work with fortran. Fixes NixOS#88449
This is the right one on cross compilation.
# If unset, assume the default hardening flags. | ||
# These are different for fortran. | ||
: ${NIX_HARDENING_ENABLE="stackprotector pic strictoverflow relro bindnow"} | ||
export NIX_HARDENING_ENABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fortran-specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - fortify & format don't work well in fortran. it's non-fatal, but we shouldn't need to set it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess this is kind of an issue since it does effect cc/c++ as well
Cross compilation fixes for blas/lapack
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)