-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] rust: 1.45 -> 1.46.0 #96890
Conversation
ffbdfaa
to
162062c
Compare
@GrahamcOfBorg build fd firefox thunderbird |
96d0dcd
to
2b9b5f7
Compare
Building |
@@ -9518,15 +9518,22 @@ in | |||
|
|||
rust_1_44 = callPackage ../development/compilers/rust/1_44.nix { | |||
inherit (darwin.apple_sdk.frameworks) CoreFoundation Security; | |||
llvmPackages = llvmPackages_9; | |||
}; | |||
rust_1_45 = callPackage ../development/compilers/rust/1_45.nix { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to leave a comment explaining why the older versions are left available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@GrahamcOfBorg eval |
Build of deno |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commit message should be:
rust: 1.45 -> 1.46.0
as you're bumping the default
Are these the only 2 things that need resolving to get this merged?:
|
I noticed that we still lock EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
firefox
, thunderbird
and thunderbird-78
are built successfully with latest rustPackages_1_46_0
.
We can remove the override (rust 1.44) in all-packages.nix
at line 20463, 23292 and 23300.
This adds the rust toolchain 1.46.0: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1460-2020-08-27 Because rustc-1.46.0 enables static PIE by default for `x86_64-unknown-linux-musl` this release will suffer from: NixOS#94228 So this commit doesn't remove the 1.45.2 release. This commit also specifies the right LLVM packages to use for each rust release.
2b9b5f7
to
c011333
Compare
Thanks for checking!
Done
Done
Done |
@GrahamcOfBorg eval |
Motivation for this change
This adds the rust toolchain 1.46.0:
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1460-2020-08-27
Because rustc-1.46.0 enables static PIE by default for
x86_64-unknown-linux-musl
this release will suffer from: #94228. So this PR doesn't remove the 1.45.2 release.This commit also specifies the right LLVM packages to use for each rust release.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)