Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 92: ^ instead of ! #160

Closed

Conversation

Ericson2314
Copy link
Member

The syntax we actually got is different than what was in the RFC. Updating the RFC to reflect this later decision.

The syntax we actually got is different than what was in the RFC. Updating the RFC to reflect this later decision.
@Ma27
Copy link
Member

Ma27 commented Aug 11, 2023

I guess it would make sense to elaborate here on why this has happened (or link the discussion around this) :)

@Ericson2314
Copy link
Member Author

NixOS/nix#6449 (comment) did this in a tagentially related feature, which set the precedent. That comment was in response to a thread elsewhere which I have yet to dig up.

@kevincox
Copy link
Contributor

kevincox commented Aug 23, 2023

We discussed this in the rfc-steering-committee meeting and decided to reject this fix.

RFCs are not documentation of the implemented feature but tracking of the design and implementation process. I think that it makes sense to leave the RFC as-is and any future changes can be made in the live documentation.

We do occasionally accept small improvements such as typo fixes and small rewordings to improve clarity, but changes to the meaning of accepted RFCs—even if that is the eventually implemented design—will be left out.

@piegamesde
Copy link
Member

I'd like to add that this decision by the committee is backed by the RFC process described in this repository's readme:

RFC documents are intended to be seen as the documentation of a decision and a snapshot of a moment in time, rather than a specification-like normative document. Think more of a Matrix Spec Proposal and less like an IETF RFC. Therefore, once accepted, RFCs should generally not be substantially changed. Only very minor changes should be submitted as amendments (via a follow-up pull request). It is the general expectation that any information intended to be normative and "outlive" the initial RFC process should live outside of the RFC document, mostly in documentation and code. These may be subject to change as usual, and of course any "substantial" changes will again require a new RFC. Usually there is no need to update the original RFC to keep it up with updates on the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants