Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edr_evm_napi::PendingTransaction.create deadlocks #189

Closed
Tracked by #211
agostbiro opened this issue Sep 22, 2023 · 1 comment
Closed
Tracked by #211

edr_evm_napi::PendingTransaction.create deadlocks #189

agostbiro opened this issue Sep 22, 2023 · 1 comment
Assignees
@Wodann
Milestone
EDR v0.2.0

Comments

@agostbiro
Copy link
Member

When calling many instances of edr_evm_napi::PendingTransaction.create in parallel from JS and awaiting them with Promise.all, the promise never resolves. Relevant code:

https://github.com/NomicFoundation/hardhat/pull/4398/files#diff-b3387221260f0e775eeb57f850b55eb260257487157b11c9ba92bc88eef84a9eR390

Definition of done

Switch to Promise.all from sequential in the linked code and make sure debug trace call JS tests pass in edr mode.
@Wodann Wodann added this to the EDR v0.2.0 milestone Oct 11, 2023
@Wodann Wodann mentioned this issue Nov 6, 2023
Closed
18 tasks
@Wodann Wodann self-assigned this Feb 13, 2024
@Wodann
Copy link
Member

Wodann commented Feb 13, 2024

The component-based implementations have been removed from edr_napi, so no need to fix this anymore

@Wodann Wodann closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Wodann Wodann

Labels
None yet
Projects
EDR
Status: Done
Milestone
EDR v0.2.0
Development

No branches or pull requests
2 participants
@agostbiro @Wodann