Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EDR_BINARY-related code from Hardhat #253

Closed
Tracked by #211
Wodann opened this issue Dec 13, 2023 · 0 comments · Fixed by NomicFoundation/hardhat#4757
Closed
Tracked by #211

Remove EDR_BINARY-related code from Hardhat #253

Wodann opened this issue Dec 13, 2023 · 0 comments · Fixed by NomicFoundation/hardhat#4757
Assignees
@Wodann
Milestone
EDR v0.2.0

Comments

@Wodann
Copy link
Member

Wodann commented Dec 13, 2023 •
edited
Loading

A previous iteration of the EDR provider used a binary executable, defined using EDR_BINARY. This approach is no longer necessary now that we have N-API bindings.

Definition of Done
Remove all references to EDR_BINARY from Hardhat
@Wodann Wodann added this to the EDR v0.2.0 milestone Dec 13, 2023
@Wodann Wodann mentioned this issue Dec 13, 2023
Closed
18 tasks
@Wodann Wodann self-assigned this Jan 12, 2024
@Wodann Wodann linked a pull request Jan 12, 2024 that will close this issue
refactor: remove EDR_BINARY NomicFoundation/hardhat#4757
Merged
@Wodann Wodann closed this as completed Jan 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Wodann Wodann

Labels
None yet
Projects
EDR
Status: Done
Milestone
EDR v0.2.0
Development

Successfully merging a pull request may close this issue.

refactor: remove EDR_BINARY NomicFoundation/hardhat
1 participant
@Wodann