-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we replay an on-chain optimism transaction using revm
?
#377
Comments
Terminology: I'll use the word vanilla to mean the unaltered EVM as proposed in the Ethereum white/yellow paper. In its current form, it's impossible to run REVM both in vanilla and Optimism mode. Rust features are supposed to be additive such that enabling a feature doesn't disable some other feature. Unfortunately, in REVM the
As a result, vanilla EVM exeuction code in EDR would need to set missing struct fields at construction and handle missing enum variants in I did some experiments to see whether I could decouple the
I did not research the Based on the design pattern used in the draft PR, I think we can use the same pattern as I used for HaltReason to also convert the With those changes, I think that would remove the last occurrences of the optimism feature flag inside "core" REVM code. Alternatives If we cannot make the base REVM implementation generic for alternative chains, we can use the generic This doesn't allow us to override the This solution doesn't follow the normal control-flow of Rust, so will be "hacky". |
No description provided.
The text was updated successfully, but these errors were encountered: